CLI: remove fixed timeouts from InteractiveCliApp unit tests; document rule#1214
Draft
CLI: remove fixed timeouts from InteractiveCliApp unit tests; document rule#1214
Conversation
Use event-loop polling until observable frame content matches instead of setTimeout(50). Document no wall-clock sleeps in cli.mdc Vitest rules. Co-authored-by: terry <terry@odd-e.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setTimeout(..., 50)waits incli/tests/InteractiveCliApp.test.tsxwithwaitForFrames, which advances the event loop viasetImmediateuntil the combined frame output satisfies the same assertions the test already made (or fails with a clear error after a turn-count cap)..cursor/rules/cli.mdcthat CLI Vitest unit tests must not use wall-clock sleeps for “letting Ink catch up”; prefer observable conditions plus event-loop turns, with E2E as the place for bounded retries where needed.Testing
pnpm cli:test