Update FormGroupLayoutLabel.tsx#120
Open
Harsh517-tech415 wants to merge 10 commits intoneolution-ch:mainfrom
Open
Update FormGroupLayoutLabel.tsx#120Harsh517-tech415 wants to merge 10 commits intoneolution-ch:mainfrom
Harsh517-tech415 wants to merge 10 commits intoneolution-ch:mainfrom
Conversation
I have made the following changes to improve the working label: 1. added stop propagation() on onClick to avoid toggle the parent component 2. improve the "?" svg
Author
|
@neotrow can you please review and merge it |
commit: |
manni497
requested changes
Dec 10, 2024
manni497
reviewed
Dec 10, 2024
Collaborator
manni497
left a comment
manni497
left a comment
There was a problem hiding this comment.
Hi @Harsh517-tech415 ,
Can you also add a new entry in the changelog?
added stop propagation on label instead of div
Author
|
Once everything is fixed, I will add a changelog |
manni497
reviewed
Dec 11, 2024
Collaborator
manni497
left a comment
manni497
left a comment
There was a problem hiding this comment.
@Harsh517-tech415 PR is fine for me, I will approve as soon as you add the changelog
Author
|
done |
manni497
previously approved these changes
Dec 16, 2024
manni497
requested changes
Dec 16, 2024
Michele-Masciave
approved these changes
Dec 18, 2024
Michele-Masciave
suggested changes
Dec 19, 2024
Michele-Masciave
approved these changes
Dec 19, 2024
manni497
previously approved these changes
Dec 20, 2024
Michele-Masciave
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made the following changes to improve the working label: