Enhancment/url validator harsh#50
Open
Harsh517-tech415 wants to merge 2 commits intoneolution-ch:mainfrom
Open
Enhancment/url validator harsh#50Harsh517-tech415 wants to merge 2 commits intoneolution-ch:mainfrom
Harsh517-tech415 wants to merge 2 commits intoneolution-ch:mainfrom
Conversation
drebrez
requested changes
Jan 7, 2025
| */ | ||
| export function validateUrl(value?: string | number | null): boolean { | ||
| try { | ||
| if (!value || typeof value !== "string") { |
Contributor
There was a problem hiding this comment.
This check can be replaced with the isNullOrEmpty or isNullOrWhitespace utility method.
| return false; | ||
| } | ||
|
|
||
| if (!value.startsWith("http://") && !value.startsWith("https://")) { |
Contributor
There was a problem hiding this comment.
Limit to only consider "http/https" protocols might not be good for a validateUrl method, maybe renaming the method to isValidHttpUrl (this naming also matches the other validation methods like isObject, isValidGuid,...) might be better.
And at this point it might be good to have both, validateUrl and validateHttpUrl, and then one can reuse the other and do additional checks, something like:
export function isValidUrl(value?: string): boolean {
try {
new URL(value);
return true;
} catch {
return false;
}
}
export function isValidHttpUrl(value?: string): boolean {
if (!isValidUrl(value)) {
return false;
}
return value.startsWith("http://") || value.startsWith("https://");
}
what you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added validateUrl utility