Add new Overload for PasswordSignInAsync#7
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new overload for the PasswordSignInAsync method that accepts a TUser entity parameter instead of an email string, reducing code duplication by refactoring the existing email-based method to delegate to the new user-based method.
- Added new
PasswordSignInAsync(TUser user, string password)method to the interface and implementation - Refactored existing
PasswordSignInAsync(string email, string password)to use the new overload - Updated changelog to document the new overload
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ITokenSignInManager.cs | Adds interface definition for new user-based PasswordSignInAsync overload |
| TokenSignManager.cs | Implements new overload and refactors existing method to reduce duplication |
| CHANGELOG.md | Documents the addition of the new method overload |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
neoscie
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.