Conversation
…nfiguration handling
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
GoogleSecrets/ConfigurationBuilderExtensions.cs:35
- Removing the explicit exception for missing ProjectName may lead to silent misconfiguration. If the behavior is intentional and relying on the provider to log a warning, please ensure that this change is clearly documented.
if (string.IsNullOrWhiteSpace(googleSecretsOptions.ProjectName)) { throw new ArgumentNullException(nameof(googleSecretsOptions.ProjectName)); }
neoscie
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant changes to the
GoogleSecretsconfiguration functionality. The most important updates include the addition of a new overload forAddGoogleSecrets, the removal of redundant code, and enhancements to the handling ofGoogleSecretsOptions.Key Changes:
New Features:
AddGoogleSecretsto allow passingGoogleSecretsOptions.Code Simplification:
GoogleSecretsProjectinConfigurationBuilderExtensions. [1] [2]AddGoogleSecretsmethod by removing the check forProjectNameinGoogleSecretsOptions.Enhancements:
ProjectNameproperty inGoogleSecretsOptionsto default to the environment variableGoogleSecretsProjectif available.GoogleSecretsProviderifProjectNameis not set.