Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the DotNetConsoleLogger static class for fallback logging, adds a CI check to validate dependency injection setup, and upgrades dependency packages to their latest versions.
- Introduces
DotNetConsoleLoggerstatic class for centralized logger initialization and management - Adds CI validation using
dotnet run -- check-depsto verify DI setup - Updates dependency packages (Scrutor, Microsoft.Extensions, test packages) to latest versions
Reviewed Changes
Copilot reviewed 25 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Comprehensive documentation update with installation guide, usage examples, and check-deps explanation |
| Neolution.DotNet.Console/DotNetConsoleLogger.cs | New static logger class providing initialization, access, and shutdown methods |
| Neolution.DotNet.Console/DotNetConsole.cs | Updated to use DotNetConsoleLogger instead of direct NLog setup |
| Neolution.DotNet.Console/DotNetConsoleException.cs | Removed obsolete serialization constructor and attributes |
| .github/workflows/ci.yml | Added CI step to validate DI setup using check-deps command |
| Various project files | Package version updates and demo application restructuring |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
neotrow
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DotNetConsoleLoggerfor fallback logging.dotnet run -- check-depsto ensure proper dependency resolution and prevent runtime errors.