refactor: add consistent DiagnosticSource categories for all logging …#2
Open
negativeeddy wants to merge 1 commit into
Open
refactor: add consistent DiagnosticSource categories for all logging …#2negativeeddy wants to merge 1 commit into
negativeeddy wants to merge 1 commit into
Conversation
…services - Add a custom DiagnosticNameAttribute in ArmMedia.Core as a shared marker (System.Diagnostics.DiagnosticNameAttribute does not exist in .NET 10) - Add [DiagnosticName] attribute to every class that creates an ILogger - Convert all ILogger<T> constructor injection to ILoggerFactory + CreateLogger - Add private const string DiagnosticCategory to each class, used in both the attribute and CreateLogger() to guarantee paired consistency - Update DiscPollingService to use UeventMonitor.DiagnosticCategory constant - Add System.Diagnostics.DiagnosticSource package reference (removed after realizing it's unnecessary in .NET 10) - Fix all test files to pass NullLoggerFactory.Instance instead of ILogger<T>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…services