Loosened backend constraints#14
Open
RikvanToor wants to merge 3 commits intonaushadh:persistent-mysql-haskellfrom
Open
Loosened backend constraints#14RikvanToor wants to merge 3 commits intonaushadh:persistent-mysql-haskellfrom
RikvanToor wants to merge 3 commits intonaushadh:persistent-mysql-haskellfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
After submitting your PR:
This PR changes the creation of
SqlBackends to some typebackendfor which the constraintsIsPersistBackend backend, BaseBackend backend ~ SqlBackend, BackendCompatible SqlBackend backendhold. This allows the user to use this package with other backends than justSqlBackend. My own use case for this is to be able to useSqlReadBackend. This way, I can run read-only queries on a different connection than writing queries.