Fix Admin API tests#4571
Merged
calculuschild merged 5 commits intonaturalcrit:masterfrom Feb 17, 2026
Merged
Conversation
G-Ambatte
added
bug
5e-Cleric
approved these changes
Jan 3, 2026
5e-Cleric
moved this from Backlog
to Waiting for Calc's First Review
in @calculuschild's backlog
github-project-automation
Bot
moved this from Waiting for Calc's First Review
to Done
in @calculuschild's backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Admin API unit tests have been failing when run locally.
Investigation has shown that the new
dbCheckmiddleware has been capturing the API calls because the database connection state is not ready (1). This is because the test file does not actually connect to the database at all, instead mocking all database calls.This is NOT an issue when testing in CircleCI, as the
dbCheckmiddleware contains an exception for test environments. However, when testing locally with the environment set to "local", the tests will fail.This PR manually sets the
readyStateto1before each Admin API test, then restores the original value afterwards.