Prevent potential NULL dereference in drmaa_wait()#7
Open
judith-ipac wants to merge 1 commit intonatefoo:mainfrom
Open
Prevent potential NULL dereference in drmaa_wait()#7judith-ipac wants to merge 1 commit intonatefoo:mainfrom
judith-ipac wants to merge 1 commit intonatefoo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In drmaa_wait(), result_job_id is assigned from session->wait(), which calls fsd_drmaa_session_wait(). In the DRMAA_JOB_IDS_SESSION_ANY case, this in turn calls fsd_drmaa_session_wait_for_any_job(), which can return NULL without raising an exception — for example if fsd_strdup() fails due to memory exhaustion.
In this case result_job_id is NULL when strlcpy() is called, causing a segfault.
This was confirmed via a core dump showing result_job_id = 0x0 and _fsd_exc_rc = 0 (indicating normal execution path, no exception raised) in drmaa_wait().
The patch adds a NULL check before the strlcpy() call, leaving job_id_out as an empty string if result_job_id is NULL.
Thanks to Claude for troubleshooting and writing this description.