feat(support-matrix): add nodeOmit to drop EOL node majors from the card#499
Merged
Conversation
The Node.js card derives its pills from the `engines` range, so `>=25` renders a `25` pill even after Node 25 reaches EOL. `nodeOmit` (a comma list of majors, sanitized like `nodeTested`) drops specified majors from the pills entirely — no pill and no `excluded` mention — while `engines` is still rendered verbatim, so the declared range is never concealed. Omission is applied before coverage/gap accounting and the headline now spans the surviving pills, so dropping the floor or ceiling major no longer leaves a dangling `→ vN` endpoint. Threaded through the query parser, resolver, inverse builder, and the /support-matrix URL-builder, with unit + boundary tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48913fc61a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Reviewer #499: `excluded` was computed across the original floor..ceiling span, so omitting an endpoint major (e.g. `^22 || ^26` with 26 dropped) left `excluded` listing majors that sit beyond the last surviving pill — `v22` headline but `excluded: 23, 24, 25`. Buffer uncovered majors and flush them only once a later pill bounds the gap on both sides; discard any trailing run past the final pill. The excluded span now shrinks together with the headline. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
nodeOmitquery param to the support-matrix badge service: a comma list of Node majors to drop from the Node.js card's pills, even when theenginesrange still permits them (e.g. an EOL runtime like Node 25 under>=25).nodeOmit=25turns pills22.20+ · 24.12+ · 25 · 26into22.20+ · 24.12+ · 26.enginesstring is still rendered verbatim, so the declared range is never hidden.nodeTested(whole-digit integers only; junk dropped).Consistency
Omission is applied before coverage/gap accounting, and the headline now spans the surviving pills, so:
excludedmention — it vanishes from the card;>=22+nodeOmit=26still showedv22 → v26with no26pill; now it retracts tov22 → v25).Threaded through
lib/support-matrix/{node,query,resolve}.ts,routes.test.ts, and the/support-matrixURL-builder (components/support-matrix-builder/index.tsx).Tests
vitest— node/query/resolve/routes suites, including boundary cases (omit floor, ceiling, all-covered majors, and an already-excluded major). Full suite: 367 passing.Not included
Per-query edge caching for
/support-matrix.{png,svg}is out of scope here — the void-platform direct-route cache key strips the query string, so it needs a platform-side fix (the static-candidate cache key), tracked separately.🤖 Generated with Claude Code