Fixup pip usage#287
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Nanvix Python build script to use a more reliable pip invocation and to fail fast when pip installation of site-packages fails, addressing Ubuntu 24.04 environments where a pip binary may be absent.
Changes:
- Simplifies pip invocation to
sys.executable -m pipto avoid relying onpip3/system Python assumptions. - Makes pip installs fail the build by adding
check=Trueto thesubprocess.run()call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ppenna
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #284
Verified by building in a container running ubuntu:24.04 base image, no pip install.