encode配置加载#340
Open
ShipinZ wants to merge 1 commit intonacos-group:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug描述:
之前配置文件中的encode属性不会被加载到GlobalNacosProperties,导致当加载全局配置时创建的ConfigService的cacheKey不包含encode属性
CacheableEventPublishingNacosServiceFactory.ConfigCreateWorker但是注解
@NacosConfigurationProperties加载的默认配置,又会默认包含encodeUTF-8,所以这导致同一个服务的cacheKey不一致会创建两次ConfigService修改内容
SubNacosProperties增加encode属性属性GlobalNacosProperties和SubNacosProperties时会使用配置文件的里的encode