test(store-redis): improve coverage from 77% to 84% and raise thresho…#96
Open
mattnichols wants to merge 1 commit into
Open
test(store-redis): improve coverage from 77% to 84% and raise thresho…#96mattnichols wants to merge 1 commit into
mattnichols wants to merge 1 commit into
Conversation
…ld to 80% - Add test exercising buildConnection() exception path directly - Raise minimumCoverage from 0.77 to 0.80 in store-redis/build.gradle - Refresh all gradle.lockfiles for Java 21 compatibility - Add CLAUDE.md with codebase guidance for Claude Code
mattnichols
force-pushed
the
feature/store-redis-coverage
branch
from
618cd2a to
9dc5442
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
store-redis was the only module below the 80% coverage target. The gap was entirely in buildConnection() and buildClusterConnection() — the existing tests mock those methods via Mockito spy, so their
bodies were never instrumented. The new test calls buildConnection() directly on a non-spy instance with an unreachable port (port 1), causing Lettuce to fail synchronously with a
RedisConnectionException, which exercises the full try block and the catch (RedisException) branch.
All other modules already exceeded 80% (range: 85%–100%).