Added the feature of delayed packages#170
Open
RemZapCypher wants to merge 1 commit intomushorg:mainfrom
Open
Conversation
glaslos
requested changes
Jan 31, 2025
Member
glaslos
left a comment
glaslos
left a comment
There was a problem hiding this comment.
How would you use this in Glutton?
|
|
||
| func (h *DelayHandler) GetDelay(port int, protocol string) time.Duration { | ||
| // Check port specific delay | ||
| for _, pd := range h.config.PerPort { |
Member
There was a problem hiding this comment.
can you solve this without a for loop?
| // Check port specific delay | ||
| for _, pd := range h.config.PerPort { | ||
| if pd.Port == port { | ||
| for _, p := range pd.Protocols { |
Member
There was a problem hiding this comment.
can you solve this without a for loop?
| config DelayConfig | ||
| } | ||
|
|
||
| func (h *DelayHandler) GetDelay(port int, protocol string) time.Duration { |
Comment on lines
+49
to
+52
| if delay < tt.minDelay || delay > tt.maxDelay { | ||
| t.Errorf("Delay %v outside expected range [%v, %v]", | ||
| delay, tt.minDelay, tt.maxDelay) | ||
| } |
Member
There was a problem hiding this comment.
use the require package for tests
| ) | ||
|
|
||
| func TestDelayHandler(t *testing.T) { | ||
| config := DelayConfig{ |
Open
Member
|
@tank0nf are you still planning to work on this issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @glaslos,
Reffering to issue: Tarpit #55
I have tried to add capability to add a delay to responses. Delay should be random in range and can be set in the config.yaml file.
Please review the changes and let me know, if their is any changes necessary.
Thank you,
Tank0nf.