Fix BasicTableView compatibility issue with Qt 6.10.3

[RiccardoCampo]

Resolves: audacity/audacity#11211

This might also resolve #59 since it mentions crashing around accessibility, but I only tested Audacity and not MuseScore.

Remove aliases to read-only StyledListView properties in BasicTableView, replace them with direct access to StyledListView's properties.

Aliases to read-only properties caused the error: Invalid property assignment: "__currentRowItem" is a read-only property when adding any Qt object to a LegacyTreeView object (e.g.: Audacity preferences and accessibility diagnostic panel).

• I signed the CLA as camporcr:
• The title of the PR describes the problem it addresses.
• Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
• The code in the PR follows the coding rules.
• I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
• The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
• No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
• There are no unnecessary changes.
• I created a unit test or vtest to verify the changes I made (if applicable).

Build configuration

audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64

[coderabbitai]

Warning

Review limit reached

@RiccardoCampo, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 48 minutes and 31 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 05406d3e-47fd-4855-94f2-9713832b08ce

📥 Commits

Reviewing files that changed from the base of the PR and between b4c61e9 and 5ce5947.

📒 Files selected for processing (2)

• framework/uicomponents/qml/Muse/UiComponents/LegacyTreeView/BasicTableView.qml
• framework/uicomponents/qml/Muse/UiComponents/LegacyTreeView/LegacyTreeView.qml

📝 Walkthrough

Walkthrough

Two files in the LegacyTreeView component are modified. In BasicTableView.qml, three internal alias properties (__currentRowItem, __currentRow, __listView) are removed, and the alternate-row color parity calculation is updated to reference listView.count directly. In LegacyTreeView.qml, the currentRow alias inside the MouseArea block is removed, and the selected(row) helper is updated to compare the row argument against root.listView.currentIndex instead of the now-removed alias.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description check	✅ Passed	The PR description is comprehensive and follows the template, including resolved issues, clear problem explanation, and completed checklist items.
Linked Issues check	✅ Passed	The PR successfully addresses the linked issue #11211 by removing problematic read-only property aliases that were causing property assignment errors.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the property alias issue in BasicTableView and LegacyTreeView, with no out-of-scope modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately reflects the main change: removing incompatible property aliases from BasicTableView to fix Qt 6.10.3 compatibility issues that prevented the preferences panel from opening.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

framework/uicomponents/qml/Muse/UiComponents/LegacyTreeView/BasicTableView.qml (1)

356-366: ⚠️ Potential issue | 🔴 Critical

Fix resizeColumnsToContents() to use correct ListView reference.

Line 359 references __listView.headerItem but no such property exists in BasicTableView. The ListView component is defined as id: listView (line 425). This causes a runtime error when resizeColumnsToContents() is called. Change __listView to listView on line 359.

Current code (line 356-366)

    function resizeColumnsToContents () {
        for (var i = 0; i < __columns.length; ++i) {
            var col = getColumn(i)
            var header = __listView.headerItem.headerRepeater.itemAt(i)
            if (col) {
                col.resizeToContents()
                if (col.width < header.implicitWidth)
                    col.width = header.implicitWidth
            }
        }
    }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@framework/uicomponents/qml/Muse/UiComponents/LegacyTreeView/BasicTableView.qml`
around lines 356 - 366, In the resizeColumnsToContents() function, the reference
to __listView.headerItem is incorrect because the ListView component is defined
as listView, not __listView. Change the __listView reference to listView in the
line where headerItem is being accessed within the function body to resolve the
runtime error.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In
`@framework/uicomponents/qml/Muse/UiComponents/LegacyTreeView/BasicTableView.qml`:
- Around line 356-366: In the resizeColumnsToContents() function, the reference
to __listView.headerItem is incorrect because the ListView component is defined
as listView, not __listView. Change the __listView reference to listView in the
line where headerItem is being accessed within the function body to resolve the
runtime error.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e613a118-39f4-40c9-a7fd-b2b63516e55a

📥 Commits

Reviewing files that changed from the base of the PR and between 5a48cf5 and b4c61e9.

📒 Files selected for processing (2)

• framework/uicomponents/qml/Muse/UiComponents/LegacyTreeView/BasicTableView.qml
• framework/uicomponents/qml/Muse/UiComponents/LegacyTreeView/LegacyTreeView.qml