Skip to content

Remove AutomationOverlay#108

Merged
RomanPudashkin merged 1 commit into
musescore:mainfrom
mathesoncalum:automation_overlay_remove
Jun 26, 2026
Merged

Remove AutomationOverlay#108
RomanPudashkin merged 1 commit into
musescore:mainfrom
mathesoncalum:automation_overlay_remove

Conversation

@mathesoncalum

Copy link
Copy Markdown
Contributor

See musescore/MuseScore#33960 (that PR needs to be merged first).

Keeping the automation module for now despite the fact that this was the only component in there. I suspect we'll need this module further down the line for configurations, etc.

Build configuration

audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 970cabb3-019e-44e4-9b7f-d3eaf350a2ac

📥 Commits

Reviewing files that changed from the base of the PR and between 5468461 and 2263434.

📒 Files selected for processing (4)
  • framework/automation/qml/Muse/Automation/AutomationOverlayLoader.qml
  • framework/automation/qml/Muse/Automation/CMakeLists.txt
  • framework/automation/qml/Muse/Automation/automationoverlay.cpp
  • framework/automation/qml/Muse/Automation/automationoverlay.h
💤 Files with no reviewable changes (4)
  • framework/automation/qml/Muse/Automation/CMakeLists.txt
  • framework/automation/qml/Muse/Automation/automationoverlay.h
  • framework/automation/qml/Muse/Automation/automationoverlay.cpp
  • framework/automation/qml/Muse/Automation/AutomationOverlayLoader.qml

📝 Walkthrough

Walkthrough

The automation QML module registration was changed to remove explicit source and QML file entries for automationoverlay.cpp, automationoverlay.h, and AutomationOverlayLoader.qml. The module definition now keeps only the URI, version, import dependencies, and the dependency fixup call.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning It lacks the required issue reference, summary, and checklist items from the template. Add a Resolves: #NNNNN line, a brief change summary, and complete the checklist with applicable checked or unchecked boxes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: deleting the AutomationOverlay component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@RomanPudashkin RomanPudashkin merged commit 8c223d8 into musescore:main Jun 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants