Skip to content

Add workspaces dialogs titles, check for update dialog title#106

Merged
kryksyh merged 1 commit into
musescore:mainfrom
dozzzzer:fix_dialog_titles
Jun 25, 2026
Merged

Add workspaces dialogs titles, check for update dialog title#106
kryksyh merged 1 commit into
musescore:mainfrom
dozzzzer:fix_dialog_titles

Conversation

@dozzzzer

Copy link
Copy Markdown
Contributor

Add workspaces dialogs titles, check for update dialog title

  • I signed the CLA as username:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

Build configuration

audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 097cf87a-218f-4497-a78c-13a79be7378a

📥 Commits

Reviewing files that changed from the base of the PR and between be0541a and 8f252a5.

📒 Files selected for processing (4)
  • framework/update/internal/appupdatescenario.cpp
  • framework/workspace/qml/Muse/Workspace/NewWorkspaceDialog.qml
  • framework/workspace/qml/Muse/Workspace/WorkspacesDialog.qml
  • framework/workspace/qml/Muse/Workspace/workspacelistmodel.cpp

📝 Walkthrough

Walkthrough

The PR adds localized titles to the new workspace and edit workspaces dialogs. It also extends two interactive dialog calls with extra UI parameters: one for the server error shown during update checks and one for the workspace reset confirmation.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The template is mostly filled, but it omits the required issue reference and the short description/motivation section. Add a Resolves: #NNNN line and a brief description of the change and motivation; keep the checklist and build config as needed.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: adding titles to workspace dialogs and the check-for-update dialog.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kryksyh kryksyh merged commit 5468461 into musescore:main Jun 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants