KDDockWidgets v2 pull directly from fork main

[kryksyh]

This is temporary change and should be reverted when KDDockWidgets v2 port is stable

Resolves: #NNNNN

• I signed the CLA as username:
• The title of the PR describes the problem it addresses.
• Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
• The code in the PR follows the coding rules.
• I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
• The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
• No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
• There are no unnecessary changes.
• I created a unit test or vtest to verify the changes I made (if applicable).

Build configuration

audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR removes the conditional kddockwidgets source dependency from the ext deps manifest. It updates framework/dockwindow_v2/CMakeLists.txt to fetch KDDockWidgets from GitHub with CMake FetchContent, set its build options, make it available, and continue linking muse_dockwindow against kddockwidgets.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description matches the template structure, but the issue reference is still a placeholder and some checklist items are unchecked.	Replace #NNNNN with the actual issue or link, and complete or justify the remaining unchecked checklist items.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: fetching KDDockWidgets v2 directly from the fork's main branch.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@framework/dockwindow_v2/CMakeLists.txt`:
- Around line 53-58: The FetchContent setup for kddockwidgets only defines a
local source directory, but QML consumers need the global
kddockwidgets_SOURCE_DIR property to stay available. Update the kddockwidgets
FetchContent declaration in CMakeLists.txt so it preserves that global property
(or otherwise sets it explicitly) and keep the existing source dir reference
consistent with what framework/dockwindow_v2/qml/Muse/Dock/CMakeLists.txt
expects when resolving KDDockWidgets headers.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 292bdf51-d2fa-4bcc-a953-89ea15180ba2

📥 Commits

Reviewing files that changed from the base of the PR and between be0541a and e9c82fd.

📒 Files selected for processing (2)

• buildscripts/cmake/ExtDepsManifest.cmake
• framework/dockwindow_v2/CMakeLists.txt

💤 Files with no reviewable changes (1)

• buildscripts/cmake/ExtDepsManifest.cmake

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Show KDDockWidgets source-dir property producers/consumers in dockwindow_v2.
rg -n -C2 'kddockwidgets_SOURCE_DIR|FetchContent_Declare\(kddockwidgets|FetchContent_MakeAvailable\(kddockwidgets' framework/dockwindow_v2

Repository: musescore/muse_framework

Length of output: 1456

---

Preserve the kddockwidgets_SOURCE_DIR global property for QML consumers.

framework/dockwindow_v2/qml/Muse/Dock/CMakeLists.txt relies on a global property to resolve the KDDockWidgets include path. Currently, FetchContent only sets this path in the local scope, causing the QML target to fail finding headers.

Proposed fix

 set(kddockwidgets_src_dir ${FETCHCONTENT_BASE_DIR}/kddockwidgets)
+set_property(GLOBAL PROPERTY kddockwidgets_SOURCE_DIR ${kddockwidgets_src_dir})

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	set(kddockwidgets_src_dir ${FETCHCONTENT_BASE_DIR}/kddockwidgets)
	FetchContent_Declare(kddockwidgets
	GIT_REPOSITORY https://github.com/musescore/KDDockWidgets.git
	GIT_TAG main
	SOURCE_DIR ${kddockwidgets_src_dir}/kddockwidgets
	)
	set(kddockwidgets_src_dir ${FETCHCONTENT_BASE_DIR}/kddockwidgets)
	set_property(GLOBAL PROPERTY kddockwidgets_SOURCE_DIR ${kddockwidgets_src_dir})
	FetchContent_Declare(kddockwidgets
	GIT_REPOSITORY https://github.com/musescore/KDDockWidgets.git
	GIT_TAG main
	SOURCE_DIR ${kddockwidgets_src_dir}/kddockwidgets
	)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@framework/dockwindow_v2/CMakeLists.txt` around lines 53 - 58, The
FetchContent setup for kddockwidgets only defines a local source directory, but
QML consumers need the global kddockwidgets_SOURCE_DIR property to stay
available. Update the kddockwidgets FetchContent declaration in CMakeLists.txt
so it preserves that global property (or otherwise sets it explicitly) and keep
the existing source dir reference consistent with what
framework/dockwindow_v2/qml/Muse/Dock/CMakeLists.txt expects when resolving
KDDockWidgets headers.