Skip to content

Fixed crash on close app #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eism merged 1 commit into from
Jun 22, 2026
+5 −0
Merged

Fixed crash on close app #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions framework/global/internal/baseapplication.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,10 @@ void BaseApplication::doDestroyContext(const ContextData& data)
s->onDeinit();
}

for (modularity::IContextSetup* s : data.setups) {
s->onDestroy();
}

qDeleteAll(data.setups);

modularity::removeIoC(data.ctxId);
Expand Down
1 change: 1 addition & 0 deletions framework/global/modularity/imodulesetup.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ class IContextSetup
virtual void onInit(const IApplication::RunMode& mode) { (void)mode; }
virtual void onAllInited(const IApplication::RunMode& mode) { (void)mode; }
virtual void onDeinit() {}
virtual void onDestroy() {}

private:
ContextPtr m_ctx;
Expand Down