Add on screen only option to getElementsByType#4746
Open
ArranTuna wants to merge 3 commits intomultitheftauto:masterfrom
Open
Add on screen only option to getElementsByType#4746ArranTuna wants to merge 3 commits intomultitheftauto:masterfrom
ArranTuna wants to merge 3 commits intomultitheftauto:masterfrom
Conversation
Member
|
I like the idea, ill code-review it soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I suggested onClientElementEnterScreen #678 but in the comments suggested that an option in getElementsByType to return on screen only would be good.
Motivation
There are scripts that try to be more efficient by applying things to only elements that are on screen, for example a script that renders text above a players head currently would have to do getElementsByType("player", root, true) and call isElementOnScreen on that list, as this is being done every frame that's inefficient. This change allows you to just do: getElementsByType("player", root, true, true) to get only on screen elements.
Test plan
This is an easy to test change, at first I just compared the sizes of #getElementsByType("ped", root, true) and #getElementsByType("ped", root, true, true) while turning camera to see it worked correctly, I then used createBlipAttachedTo to make sure the actually on screen elements were the ones in the table.