Fix streamer bug where objects can constantly stream in and out#4744
Open
ArranTuna wants to merge 2 commits intomultitheftauto:masterfrom
Open
Fix streamer bug where objects can constantly stream in and out#4744ArranTuna wants to merge 2 commits intomultitheftauto:masterfrom
ArranTuna wants to merge 2 commits intomultitheftauto:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4743
Worked with codex to develop a fix for this bug, first it added "Avoid swap ping-pong when two candidates are almost the same distance" but that wasn't enough to fix it on it's own, so a last stream out time was added.
Motivation
A very old MTA bug that can cause FPS instability when a player is affected by it.
Test plan
Was a little hard to test this, but could reproduce the bug in under 1 minute, by constantly moving slightly with freecam. However after adding the fix I could not reproduce it when testing for at least 5 minutes and observed no other issues.
Checklist
Made sure to comply with the coding guidelines such as using std::uint32_t