Add support for extensions of the multiaddr interface.#135
Open
willscott wants to merge 1 commit intomultiformats:masterfrom
Open
Add support for extensions of the multiaddr interface.#135willscott wants to merge 1 commit intomultiformats:masterfrom
willscott wants to merge 1 commit intomultiformats:masterfrom
Conversation
willscott
force-pushed
the
feat/custom-multiaddr
branch
from
2b598a8 to
469fa69
Compare
This introduces a feature flag `Custom` that can be used to allow for parsing and management of protocols that are not part of the hard-coded set of known multiaddrs. This parallels the more permissive support that is found in js and golang implementations. by default, unknown protocols will not be parsed, since the semantics of how to parse their arguments cannot be known, but they can be manually constructed and then serialized to string. Specific extension protocols can be registered in a protocol registry to extend the default set and allow for handling of multiaddrs using those additional protocols more naturally.
willscott
force-pushed
the
feat/custom-multiaddr
branch
from
469fa69 to
2904bdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a feature flag
Customthat can be used to allow for parsing and management of protocols that are not part of the hard-coded set of known multiaddrs.This parallels the more permissive support that is found in js and golang implementations.
by default, unknown protocols will not be parsed, since the semantics of how to parse their arguments cannot be known, but they can be manually constructed and then serialized to string. Specific extension protocols can be registered in a protocol registry to extend the default set and allow for handling of multiaddrs using those additional protocols more naturally.