remove the date-fns dependency. add a tool to see the bundle components.#7
Open
elee1766 wants to merge 2 commits intomultibaseco:mainfrom
Open
remove the date-fns dependency. add a tool to see the bundle components.#7elee1766 wants to merge 2 commits intomultibaseco:mainfrom
elee1766 wants to merge 2 commits intomultibaseco:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this reduces the bundle size from 57kb -> 28kb, about half!
this is bc we only really need a tiny subset of what the functions from date-fns do.
it should produce identical output in all cases, regardless of system timezone or locale.
it also adds rollup correctly as a versioned development dependency, which will be used with
yarn build, and a rollup plugin for visualizing the bundle.