Merged
Conversation
dlon
approved these changes
Nov 17, 2020
Member
dlon
left a comment
dlon
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
faern
force-pushed
the
upgrade-some-network-dependencies
branch
from
716bc84 to
517ca5a
Compare
For context: rust-lang/rust#78802
faern
force-pushed
the
upgrade-some-network-dependencies
branch
2 times, most recently
from
0467ba1 to
fdc12c3
Compare
dlon
approved these changes
Nov 18, 2020
Member
dlon
left a comment
dlon
left a comment
There was a problem hiding this comment.
Is there a reason for downgrading again?
Reviewed 1 of 1 files at r2.
Reviewable status:
faern
commented
Nov 18, 2020
Member
Author
faern
left a comment
faern
left a comment
There was a problem hiding this comment.
There were build errors on Travis. And I did not have the time to debug. I felt it could mess around too much with various other in-progress features. Someone who has the time to test it more properly should do a full upgrade probably.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started out by wanting to bump
miowandsocket2in order to help this PR progress: rust-lang/rust#78802But I then realized that why not just do a full
cargo updateto stay on top of things.Git checklist:
CHANGELOG.mdunder the[Unreleased]header.This change is