[combobox][select] Anchor multiple selection to first selected item - #5573
Draft
atomiks wants to merge 2 commits into
Draft
[combobox][select] Anchor multiple selection to first selected item#5573atomiks wants to merge 2 commits into
atomiks wants to merge 2 commits into
Conversation
atomiks
added
component: select
commit: |
Bundle size
PerformanceTotal duration: 1,200.94 ms -95.99 ms(-7.4%) | Renders: 76 (+0) | Paint: 1,942.05 ms -147.34 ms(-7.1%)
14 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3077
Closes #5549
Decision
Multiple-selection popups continue to open from a selected item. When more than one item is selected, the anchor is the first selected item in rendered order rather than the most recently added value. This follows the single-selection rule and keeps the opening position stable when values are toggled or supplied in a different order.
Changes
itemscollections.Performance
Synthetic Chromium benchmark with 500 rendered items:
The extreme 250-selected Combobox case adds 1.76 ms; the other measured scenarios remained within benchmark noise.