⚡ Optimize DOM traversal in i18n replacement#31
Conversation
Replaced `document.querySelectorAll('*')` with `document.createTreeWalker` to avoid creating a large NodeList and improve iteration performance.
Optimized attribute iteration to use a standard for loop instead of `Array.from` to reduce memory allocation.
Added `NodeFilter` to test globals to support TreeWalker testing.
Co-authored-by: cmuench <211294+cmuench@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
document.querySelectorAll('*')withdocument.createTreeWalker(document.documentElement, NodeFilter.SHOW_ELEMENT)inreplaceI18nPlaceholders.forloop overel.attributesinstead ofArray.from(el.attributes).forEach.tests/utils.test.jsto exposeNodeFilterin the test environment.🎯 Why:
document.querySelectorAll('*')forces the browser to visit every node and create a static NodeList, which is O(N) memory and time.TreeWalkerallows traversing the DOM without allocating a large list of nodes.Array.fromfor attributes reduces temporary object allocation during traversal.📊 Measured Improvement:
PR created automatically by Jules for task 507795617736555274 started by @cmuench