Conversation
- Replaced manual string escaping with `JSON.stringify` to correctly handle all special characters. - Handled quoting logic for placeholders inside and outside quotes. - Escaped `$` characters in replacement values to prevent regex replacement issues. - Added regression tests in `tests/security.test.js`. Co-authored-by: cmuench <211294+cmuench@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR fixes a security vulnerability where custom payloads could be injected with invalid JSON or malicious content due to insufficient escaping. It also fixes a bug where
$characters in values would cause incorrect replacements.The fix involves:
JSON.stringify(value)to generate safe JSON representations of values.$characters in the replacement string to$$to preventString.prototype.replacefrom interpreting them as special patterns (e.g.,$&).A new test file
tests/security.test.jshas been added to verify the fix and prevent regressions.PR created automatically by Jules for task 11253219302830921117 started by @cmuench