Skip to content

fix(acestep-cpp): resolve relative model paths in options #8993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mudler merged 8 commits into from
Mar 14, 2026
Merged

fix(acestep-cpp): resolve relative model paths in options #8993

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
02e54e2
fix(acestep-cpp): resolve relative model paths in options
localai-bot Mar 13, 2026
189d3c8
Apply suggestion from @mudler
mudler Mar 13, 2026
9eb8332
test: fix acestep tests to not join modeldir in options
localai-bot Mar 13, 2026
c4555c2
fix: change bpm parameter type to float32 to match C++ API signature
localai-bot Mar 13, 2026
c3d92a7
test: fix TestLoadModel and TestSoundGeneration to use baseDir for mo…
localai-bot Mar 13, 2026
91606b1
Apply suggestions from code review
mudler Mar 13, 2026
85046b5
Apply suggestions from code review
mudler Mar 13, 2026
2d69650
Merge branch 'master' into fix-acestep-cpp-model-loading-8991
mudler Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion backend/go/acestep-cpp/goacestepcpp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package main
import (
"fmt"
"os"
"path/filepath"
"strings"

"github.com/mudler/LocalAI/pkg/grpc/base"
Expand All @@ -11,7 +12,7 @@ import (

var (
CppLoadModel func(lmModelPath, textEncoderPath, ditModelPath, vaeModelPath string) int
CppGenerateMusic func(caption, lyrics string, bpm int, keyscale, timesignature string, duration, temperature float32, instrumental bool, seed int, dst string, threads int) int
CppGenerateMusic func(caption, lyrics string, bpm int, keyscale, timesignature string, duration, temperature float32, instrumental bool, seed int, dst string, threads int)
Comment thread
mudler marked this conversation as resolved.
Outdated
)

type AceStepCpp struct {
Expand All @@ -22,6 +23,9 @@ func (a *AceStepCpp) Load(opts *pb.ModelOptions) error {
// ModelFile is the LM model path
lmModel := opts.ModelFile

// Get the base directory from ModelFile for resolving relative paths
baseDir := filepath.Dir(lmModel)

var textEncoderModel, ditModel, vaeModel string

for _, oo := range opts.Options {
Expand Down Expand Up @@ -52,6 +56,29 @@ func (a *AceStepCpp) Load(opts *pb.ModelOptions) error {
return fmt.Errorf("vae_model option is required")
}

// Resolve relative paths to the base directory
// If the path doesn't start with "/" it's relative
if !filepath.IsAbs(textEncoderModel) {
textEncoderModel = filepath.Join(baseDir, textEncoderModel)
}
if !filepath.IsAbs(ditModel) {
ditModel = filepath.Join(baseDir, ditModel)
}
if !filepath.IsAbs(vaeModel) {
vaeModel = filepath.Join(baseDir, vaeModel)
}

// Also resolve the lmModel if it's relative
if !filepath.IsAbs(lmModel) {
lmModel = filepath.Join(baseDir, lmModel)
}

fmt.Fprintf(os.Stderr, "[acestep-cpp] Resolved paths:\n")
fmt.Fprintf(os.Stderr, " LM Model: %s\n", lmModel)
fmt.Fprintf(os.Stderr, " Text Encoder: %s\n", textEncoderModel)
fmt.Fprintf(os.Stderr, " DiT Model: %s\n", ditModel)
fmt.Fprintf(os.Stderr, " VAE Model: %s\n", vaeModel)

if ret := CppLoadModel(lmModel, textEncoderModel, ditModel, vaeModel); ret != 0 {
return fmt.Errorf("failed to load acestep models (error code: %d)", ret)
}
Expand Down
Loading