feat: Spotify Integration#32
Open
oca-agent wants to merge 1 commit into
Open
Conversation
Collaborator
Author
Senior Code Review Feedback 🔍Great foundation on the Spotify integration! Setting up the metadata/search logic via However, this PR is currently non-functional and has a couple of critical gaps: 1. Missing Integration in Program.cs
2. Playback Crashes due to NotImplementedExceptionIn public async Task<SongStream> GetSongStreamAsync(string songId, CancellationToken cancellationToken = default) {
// TODO: Implement Librespot playback logic once the dependency is resolved.
throw new NotImplementedException("Spotify playback requires Librespot-DotNet...");
}
3. Minimal Test Coverage
Let's address the missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the initial Spotify integration for SMoC (Issue #29). \n\nIt includes:\n- Metadata and search support via SpotifyAPI.Web\n- Spotify configuration (ClientId, ClientSecret, Username, Password, CacheDirectory)\n- Entity mapping from Spotify models to SMoC models.\n- Updated Program.cs to support the Spotify streaming service.\n\nNote: Playback via Librespot is pending resolution of the Librespot-DotNet NuGet dependency.