drm_common: Be smarter when deciding on which CRTC and Encoder to use#5769
Closed
xantoz wants to merge 1 commit intompv-player:masterfrom
Closed
drm_common: Be smarter when deciding on which CRTC and Encoder to use#5769xantoz wants to merge 1 commit intompv-player:masterfrom
xantoz wants to merge 1 commit intompv-player:masterfrom
Conversation
Inspired by kmscube, first try to pick the Encoder and CRTC already associated with the selected Connector, if any. Otherwise try to find the first matching encoder & CRTC like before. This should improve behavior somewhat when run on a multi screen setup with regards to deinit and VT switching, and should allow you to do stuff like see the fbcon terminal on one screen with video playing on the other, as well as not having one of the screens go blank after deinit if it wasn't previously (still not fool-proof. Sometimes you still end up with a blank screen where you previously had a cloned display of your fbcon). This is also preparatory for switching over to atomic modesetting, as doing modesetting via drmModeAtomicCommit will fail when you're trying to use a CRTC that is currently tied up to another Encoder & Connector, while drmModeSetCrtc is able to "steal" the CRTC in this case.
Member
Author
|
Closing because this commit was merged with #5714 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from a PR (LongChair#1) to the PR about drm atomic improvments (#5714), as this commit improves multi-screen behavior even standalone.
I agree that my changes can be relicensed to LGPL 2.1 or later.