Skip to content

command: show circles in lists instead of bold#18160

Open
guidocella wants to merge 1 commit into
mpv-player:masterfrom
guidocella:list-circle
Open

command: show circles in lists instead of bold#18160
guidocella wants to merge 1 commit into
mpv-player:masterfrom
guidocella:list-circle

Conversation

@guidocella

@guidocella guidocella commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Bolding the selected item breaks the alignment in lists with similarly-named items, so prepend a filled circle instead.

This allows to quickly differentiate the selected item with a different color while still working with color blindness.

@sfan5 sfan5 self-requested a review June 19, 2026 18:17
Bolding the selected item breaks the alignment in lists with
similarly-named items, so prepend a filled circle instead.

This allows to quickly differentiate the selected item with a different
color while still working with color blindness.
@kasper93

Copy link
Copy Markdown
Member

Is this consistent with select.lua highlight selection?

@guidocella

Copy link
Copy Markdown
Contributor Author

That stopped being consistent long ago when it inverted the background color instead of using --osd-selected-color. Which can't be done in show-text because the selected item needs to be in its own ASS event.

@sfan5 sfan5 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@kasper93 kasper93 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an option to provide backward compatibility.

@guidocella

Copy link
Copy Markdown
Contributor Author

I don't think it's worth adding an option as nobody ever expressed desire for the bold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants