TOOLS/matroska.py: add size constraint for fixed size binary data#18151
Open
kasper93 wants to merge 3 commits into
Open
TOOLS/matroska.py: add size constraint for fixed size binary data#18151kasper93 wants to merge 3 commits into
kasper93 wants to merge 3 commits into
Conversation
If we don't read the data it shouldn't set the element as present.
Those are fixed size per RFC and read as such in demux_mkv.c, fixes OOB access in some cases that were missing the checks there.
After previous commit, those sizes are checked in parser.
sfan5
approved these changes
Jun 19, 2026
| self.structname = "ebml_" + self.fieldname | ||
| self.elid = elid | ||
| self.valtype = valtype | ||
| self.length = int(length) if length is not None else 0 |
Member
There was a problem hiding this comment.
Suggested change
| self.length = int(length) if length is not None else 0 | |
| self.length = int(length or "0") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.