Added a feature to specify the fields to output#17
Open
global-roam wants to merge 19 commits intomperdeck:masterfrom
Open
Added a feature to specify the fields to output#17global-roam wants to merge 19 commits intomperdeck:masterfrom
global-roam wants to merge 19 commits intomperdeck:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Matt
I've added a feature to allow the fields to be output to be specified as a list of strings. I know your normal policy is to raise an issue first, but we needed this feature quickly and I've already implemented it.
I wanted to get your feedback on it first because I know it might not the the right "fit" for the library. If you're interested in the feature I'll follow the rest of the feature request process and update the documentation + make and modifications, etc.
Thanks
Dylan