feat: add defensive queue to _sendEventStream to prevent event loss#75
Draft
crisryantan wants to merge 1 commit intomparticle-integrations:mainfrom
Draft
Conversation
Buffer events in eventStreamQueue when window.Rokt.__event_stream__ is not yet available, and flush them in FIFO order once it is. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eventStreamQueuebuffer in_sendEventStreamso that events are queued (instead of silently dropped) whenwindow.Rokt.__event_stream__is not yet available__event_stream__becomes available on the nextprocessEventcallTest plan
__event_stream__is not defined" and "should not throw whenwindow.Roktis undefined") to verify events are queued rather than dropped__event_stream__becomes available"Made with Cursor