feat: pass mParticle session ID to Rokt SDK on launcher creation#74
Open
crisryantan wants to merge 1 commit intomparticle-integrations:mainfrom
Open
Conversation
Read the current mParticle session ID from sessionManager.getSession() in attachLauncher() and include it as mpSessionId in the options object passed to Rokt.createLauncher. This enables the Rokt SDK to associate dual-send events with the originating mParticle session. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.mParticle.sessionManager.getSession()inattachLauncher()and passes it asoptions.mpSessionIdtoRokt.createLauncherChanges
src/Rokt-Kit.js: InattachLauncher(), safely read the mParticle session ID (with null checks forsessionManageravailability) and include it in the options object passed to bothcreateLauncherandcreateLocalLaunchertest/src/tests.js: AddedsessionManagermock to mParticle stubs, updatedMockRoktForwarderto capturempSessionId, and added test cases verifying the session ID is passed when available and omitted whensessionManageris unavailableCompanion PR
mpSessionIdthrough the launcher options, stores it inPartnerConfigurationService, auto-refreshes it via__event_stream__events, and includes it in thev2/sessions/eventsrequest bodyTest Plan
mpSessionIdpresence whensessionManageris availablempSessionIdabsence whensessionManageris unavailableMade with Cursor