-
Notifications
You must be signed in to change notification settings - Fork 2
feat: sync Rokt session ID to mParticle via setIntegrationAttribute #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexs-mparticle
merged 5 commits into
mparticle-integrations:development
from
crisryantan:feature/sync-rokt-session-id-to-mparticle
Mar 24, 2026
+408
−3
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ec78fab
feat: sync Rokt session ID to mParticle via setIntegrationAttribute
crisryantan 35bee64
fix: address PR review feedback
crisryantan b5a58c5
fix: add the dist files again without any changes
crisryantan 49a2e36
fix: log selectPlacements event on failure and missing sessionId paths
crisryantan 0ced2e6
fix: revert dist/ files to previous state
crisryantan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -412,10 +412,40 @@ var constructor = function () { | |
| attributes: selectPlacementsAttributes, | ||
| }); | ||
|
|
||
| // Log custom event for selectPlacements call | ||
| logSelectPlacementsEvent(selectPlacementsAttributes); | ||
| var selection = self.launcher.selectPlacements(selectPlacementsOptions); | ||
|
|
||
| // After selection resolves, sync the Rokt session ID back to mParticle | ||
| // as an integration attribute so server-side integrations can link events. | ||
| // We log the custom event AFTER setting the attribute because | ||
| // setIntegrationAttribute alone doesn't fire a network request — | ||
| // if the user closes the page before another event fires, the server | ||
| // would never receive the session ID. | ||
| if (selection && typeof selection.then === 'function') { | ||
| selection | ||
| .then(function (sel) { | ||
| if (sel && sel.context && sel.context.sessionId) { | ||
| sel.context.sessionId | ||
| .then(function (sessionId) { | ||
| _setRoktSessionId(sessionId); | ||
| logSelectPlacementsEvent( | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @crisryantan Should we also |
||
| selectPlacementsAttributes | ||
| ); | ||
| }) | ||
| .catch(function () { | ||
| logSelectPlacementsEvent( | ||
| selectPlacementsAttributes | ||
| ); | ||
| }); | ||
| } else { | ||
| logSelectPlacementsEvent(selectPlacementsAttributes); | ||
| } | ||
| }) | ||
| .catch(function () { | ||
| logSelectPlacementsEvent(selectPlacementsAttributes); | ||
| }); | ||
| } | ||
|
|
||
| return self.launcher.selectPlacements(selectPlacementsOptions); | ||
| return selection; | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -525,6 +555,25 @@ var constructor = function () { | |
| } | ||
| } | ||
|
|
||
| function _setRoktSessionId(sessionId) { | ||
| if (!sessionId || typeof sessionId !== 'string') { | ||
| return; | ||
| } | ||
| try { | ||
| var mpInstance = window.mParticle.getInstance(); | ||
| if ( | ||
| mpInstance && | ||
| typeof mpInstance.setIntegrationAttribute === 'function' | ||
| ) { | ||
| mpInstance.setIntegrationAttribute(moduleId, { | ||
| roktSessionId: sessionId, | ||
| }); | ||
| } | ||
| } catch (e) { | ||
| // Best effort — never let this break the partner page | ||
| } | ||
| } | ||
|
|
||
| function onUserIdentified(filteredUser) { | ||
| self.filters.filteredUser = filteredUser; | ||
| self.userAttributes = filteredUser.getAllUserAttributes(); | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.