fix: retry writePageViews with fewer records on quota failure - #125
Closed
alexs-mparticle wants to merge 3 commits into
Closed
fix: retry writePageViews with fewer records on quota failure#125alexs-mparticle wants to merge 3 commits into
alexs-mparticle wants to merge 3 commits into
Conversation
When localStorage is full, evict the oldest page-view records one by one and retry until the write succeeds or no records remain. Preserves the most-recent data under quota pressure instead of discarding the entire write.
alexs-mparticle
force-pushed
the
fix/page-view-quota-eviction
branch
from
August 19, 2026 19:41
0032ff2 to
3ca27d7
Compare
Collaborator
Author
|
closed in favor of #126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writePageViewsfails due to localStorage quota, evict the oldest record and retry — continuing until the write succeeds or no records remainlet+ immutableslice(1)instead of mutating aconstarrayWhy
~385
quotaPAGE_VIEW_CAPTURE_FAILEDerrors/day in Datadog. The browser's total origin localStorage is full, so the write fails even with the 25-record cap in place. Evicting progressively fewer records may succeed when there is some space available, just not enough for all 25.Test plan
🤖 Generated with Claude Code