chore: extract capPageViews helper and remove dead writeNamespacedFieldWithinBudget - #124
Merged
Merged
Conversation
crisryantan
approved these changes
Aug 19, 2026
Collaborator
|
🎉 This PR is included in version 1.34.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capPageViewshelper inpageViewStorage.tsto deduplicate the.slice(-PAGE_VIEWS_MAX_COUNT)call that was duplicated in bothwritePageViewsandbuildPageEventswriteNamespacedFieldWithinBudgetfromstorage.ts— it became dead code when PR fix: limit page-view history to 25 most-recent records #123 switchedwritePageViewsfrom the byte-budget eviction strategy to the 25-record count capNo behavioral changes.
Test plan
npm run lint)npm run build)npm run test) — pre-existingERR_REQUIRE_ESMjsdom issue unrelated to this change🤖 Generated with Claude Code