Skip to content

Add Translation.value and .properties, with data model contents#3802

Open
eemeli wants to merge 3 commits intomozilla:mainfrom
eemeli:translation-value
Open

Add Translation.value and .properties, with data model contents#3802
eemeli wants to merge 3 commits intomozilla:mainfrom
eemeli:translation-value

Conversation

@eemeli
Copy link
Copy Markdown
Member

@eemeli eemeli commented Oct 9, 2025

Adds the JSON fields .value (required) and .properties (optional, default None) to Translation, and sets them by parsing the .string at all places where translation objects are created.

These fields are not (yet!) read anywhere, which also matches the corresponding Entity fields. The intent is to submit a follow-up PR that changes the REST API to pass these fields rather than .string for all entities and translations, in both requests and replies.

The data migration included here is... heavy. It needs to read, parse, and modify all Translation objects. That'll take a while even on a high-end machine.

@eemeli eemeli force-pushed the translation-value branch from 2ce9721 to e0fe8ac Compare October 13, 2025 18:58
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 70.93023% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.93%. Comparing base (91be114) to head (a9d46cf).

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eemeli eemeli force-pushed the translation-value branch from 2d56a37 to 695bd1e Compare March 31, 2026 20:19
@eemeli eemeli requested a review from mathjazz March 31, 2026 20:24
@eemeli eemeli marked this pull request as ready for review March 31, 2026 20:33
Copy link
Copy Markdown
Collaborator

@mathjazz mathjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. The code looks good.

We need an explicit deployment plan, including:

  • expected runtime on prod-ish data
  • rollback/failure plan
  • whether this should be split into schema migration + offline/backfill command instead of a blocking Django migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants