Add Translation.value and .properties, with data model contents#3802
Open
eemeli wants to merge 3 commits intomozilla:mainfrom
Open
Add Translation.value and .properties, with data model contents#3802eemeli wants to merge 3 commits intomozilla:mainfrom
eemeli wants to merge 3 commits intomozilla:mainfrom
Conversation
2ce9721 to
e0fe8ac
Compare
Codecov Report❌ Patch coverage is 🚀 New features to boost your workflow:
|
e0fe8ac to
87ef36f
Compare
87ef36f to
2d56a37
Compare
2d56a37 to
695bd1e
Compare
mathjazz
reviewed
Apr 3, 2026
Collaborator
mathjazz
left a comment
There was a problem hiding this comment.
Thanks for the patch. The code looks good.
We need an explicit deployment plan, including:
- expected runtime on prod-ish data
- rollback/failure plan
- whether this should be split into schema migration + offline/backfill command instead of a blocking Django migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the JSON fields
.value(required) and.properties(optional, default None) to Translation, and sets them by parsing the.stringat all places where translation objects are created.These fields are not (yet!) read anywhere, which also matches the corresponding Entity fields. The intent is to submit a follow-up PR that changes the REST API to pass these fields rather than
.stringfor all entities and translations, in both requests and replies.The data migration included here is... heavy. It needs to read, parse, and modify all Translation objects. That'll take a while even on a high-end machine.