Skip to content

Track transform for bboxes separately from the canvas#20855

Open
nicolo-ribaudo wants to merge 2 commits intomozilla:masterfrom
nicolo-ribaudo:canvas-transform-track-independently
Open

Track transform for bboxes separately from the canvas#20855
nicolo-ribaudo wants to merge 2 commits intomozilla:masterfrom
nicolo-ribaudo:canvas-transform-track-independently

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Collaborator

This patch works towards the goal of being able to track bboxes without doing a full render. The remaining bbox tracking that relies on the canvas is for text metrics.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 41.12903% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.24%. Comparing base (a55cec4) to head (a320efd).

Files with missing lines Patch % Lines
src/display/canvas_dependency_tracker.js 38.09% 39 Missing ⚠️
src/display/canvas.js 30.61% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20855      +/-   ##
==========================================
- Coverage   55.97%   55.24%   -0.73%     
==========================================
  Files         218      218              
  Lines       59033    59123      +90     
==========================================
- Hits        33041    32665     -376     
- Misses      25992    26458     +466     
Flag Coverage Δ
fonttest 8.66% <0.00%> (-0.01%) ⬇️
unittest 55.19% <41.12%> (-0.04%) ⬇️
unittestcli ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nicolo-ribaudo nicolo-ribaudo force-pushed the canvas-transform-track-independently branch from 843a1f2 to a1d8271 Compare March 30, 2026 15:14
@nicolo-ribaudo nicolo-ribaudo force-pushed the canvas-transform-track-independently branch from a1d8271 to b8eada3 Compare April 13, 2026 09:01
@nicolo-ribaudo nicolo-ribaudo force-pushed the canvas-transform-track-independently branch 2 times, most recently from f20d1eb to 702a12c Compare May 5, 2026 08:59
This patch works towards the goal of being able to track bboxes without
doing a full render. The remaining bbox tracking that relies on the
canvas is for text metrics.
Comment thread src/shared/util.js
}

// Multiplies m (an array-based transform) by md (a DOMMatrix transform).
static multiplyByDOMMatrix(m, md) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this method no longer used, given the other changes in this patch?
If so, please remove it to avoid shipping dead code in the builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants