Bug 2059503 - Ensure errors are not put into the client_info or any other internal section - #3564
Open
badboy wants to merge 1 commit into
Open
Bug 2059503 - Ensure errors are not put into the client_info or any other internal section#3564badboy wants to merge 1 commit into
badboy wants to merge 1 commit into
Conversation
badboy
force-pushed
the
ensure-errors-are-not-put-into/tnnwnklmqvvw
branch
from
July 31, 2026 10:40
67e3f03 to
eaa832a
Compare
badboy
force-pushed
the
ensure-errors-are-not-put-into/tnnwnklmqvvw
branch
from
July 31, 2026 10:41
eaa832a to
f7d891a
Compare
jeddai
reviewed
Jul 31, 2026
Comment on lines
+178
to
+186
| // string JUST outside the limits, forcing this to record an error. | ||
| let term = "a".repeat(255) + "b"; | ||
| glean::update_attribution(AttributionMetrics { | ||
| source: Some("rlb-tests".into()), | ||
| medium: Some("cargo-test".into()), | ||
| campaign: Some("testing".into()), | ||
| term: Some(term), | ||
| content: None, | ||
| }); |
Member
There was a problem hiding this comment.
Does this subsequently test that the error doesn't show up in the client_info or other sections?
Member
Author
There was a problem hiding this comment.
yup! This test specifically fills a ping with data and then checks the resulting payload against the (bundled) ping schema.
The test with this addtions fails without the fix from this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.