sqlite: Ignore ExecuteReturnedResults on PRAGMA calls - #3561
Merged
Conversation
There's rare occasions where that error is returned for ... I don't know why. I couldn't get `query_row_and_then` to work on that same pragma either. This code is copied from appservices: https://github.com/mozilla/application-services/blob/407a2421c6f731b921894927cdf9a6bacaa3813d/components/support/sql/src/conn_ext.rs#L45-L63
jeddai
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's rare occasions where that error is returned for ... I don't know why. I couldn't get
query_row_and_thento work on that same pragma either.This code is copied from appservices:
https://github.com/mozilla/application-services/blob/407a2421c6f731b921894927cdf9a6bacaa3813d/components/support/sql/src/conn_ext.rs#L45-L63
fwiw hitting this error seems to be what's causing the iOS errors on #3538