Skip to content

Bug 2049317 - Update to use zig 0.16 and maturin 1.14 for packaging additional Python wheels - #3549

Draft
badboy wants to merge 1 commit into
mainfrom
update-to-use-zig-0.16-and-mat/pxrntszzmuwo
Draft

Bug 2049317 - Update to use zig 0.16 and maturin 1.14 for packaging additional Python wheels#3549
badboy wants to merge 1 commit into
mainfrom
update-to-use-zig-0.16-and-mat/pxrntszzmuwo

Conversation

@badboy

@badboy badboy commented Jul 22, 2026

Copy link
Copy Markdown
Member

No description provided.

@badboy
badboy requested a review from a team as a code owner July 22, 2026 18:57
@badboy
badboy requested review from jeddai and removed request for a team July 22, 2026 18:57
@badboy
badboy marked this pull request as draft July 22, 2026 19:37
@badboy
badboy force-pushed the update-to-use-zig-0.16-and-mat/pxrntszzmuwo branch from 353d165 to 2e13a30 Compare July 22, 2026 19:57
@badboy

badboy commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

one issue filed as PyO3/maturin#3274

@badboy
badboy force-pushed the update-to-use-zig-0.16-and-mat/pxrntszzmuwo branch 2 times, most recently from 20e93a1 to 159aa1b Compare July 23, 2026 17:38
@badboy

badboy commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

I have a test run of this on Windows ARM as provided by GitHub actions.
CI code is here: https://github.com/fnordig/test-repo/blob/main/.github/workflows/build-test-deploy.yml#L94-L131
Latest run: https://github.com/fnordig/test-repo/actions/runs/30012410646/job/89223629709

This is currently indeed broken because of the upstream issue I filed, fixed and which got merged:
The definition file exports only the PyInit_glean._uniffi symbol, hiding all others, most notably UNIFFI_META_NAMESPACE_GLEAN which uniffi-bindgen uses to generate the bindings. We'll have to wait for a release.

@badboy
badboy force-pushed the update-to-use-zig-0.16-and-mat/pxrntszzmuwo branch from 159aa1b to 0eb9f81 Compare July 23, 2026 18:53
@badboy

badboy commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

I now have a test run using upstream maturin (from git), with my patch: https://github.com/fnordig/test-repo/actions/runs/30039673820

This now looks good.

@badboy
badboy force-pushed the update-to-use-zig-0.16-and-mat/pxrntszzmuwo branch from 0eb9f81 to ceff63a Compare July 27, 2026 08:42
@badboy

badboy commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

Turns out that whole __chkstk thing isn't needed. The issue was that maturin was hiding all those symbols. With the upstream fix all symbols are visible again and thus linking works.

Note: still requires a new maturin release first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant