sqlite: Handling errors better#3490
Open
badboy wants to merge 3 commits into
Open
Conversation
badboy
added
needs:data-review
Member
Author
|
/run-ios |
badboy
force-pushed
the
sqlite/handle-further-things
branch
from
4c4ff0c to
98b6c6c
Compare
badboy
force-pushed
the
sqlite/handle-further-things
branch
from
98b6c6c to
a63574d
Compare
badboy
force-pushed
the
sqlite/handle-further-things
branch
from
a63574d to
9eecf5d
Compare
badboy
force-pushed
the
sqlite/tests
branch
2 times, most recently
from
57a14fc to
8fbdb27
Compare
badboy
force-pushed
the
sqlite/handle-further-things
branch
from
9eecf5d to
5a2201e
Compare
badboy
force-pushed
the
sqlite/handle-further-things
branch
from
5a2201e to
39cf2ad
Compare
The previous refactoring duplicated some of the logic between different parts. Now we unify them again.
badboy
force-pushed
the
sqlite/handle-further-things
branch
from
39cf2ad to
a261e68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A trio of improvements on how we handle errors, including some error metrics.
This is the last set of commits of what #3405 pulls in.
There's some followups coming still though.