Implement the label verifier against sqlite storage#3481
Open
badboy wants to merge 7 commits into
Open
Conversation
Base automatically changed from
sqlite-measure-database-on-dis/knsyxourwprp
to
main-sqlite
June 4, 2026 14:48
badboy
force-pushed
the
correctly-validate-usage-of-ke/opmozvvytyzq
branch
from
903b5b8 to
7c13406
Compare
badboy
force-pushed
the
correctly-validate-usage-of-ke/opmozvvytyzq
branch
from
7c13406 to
892c088
Compare
Member
Author
|
I'm not perfectly happy where I had to do the split in commits here. I need to give this a proper look in this shape myself. |
badboy
force-pushed
the
correctly-validate-usage-of-ke/opmozvvytyzq
branch
3 times, most recently
from
fda2b98 to
aca536b
Compare
It's now easier to do: query the column and count. There's some complications when we get to dual-labeled metrics, but that comes later.
This will unify label check code: all cases are handled through the same code paths, just that for the static label variant we don't need to do any more checks.
badboy
force-pushed
the
correctly-validate-usage-of-ke/opmozvvytyzq
branch
from
aca536b to
3b99ae5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's now easier to do: query the column and count.
There's some complications when we get to dual-labeled metrics, but that
comes later.