fix(functional-tests): harden tests against sign-out race condition#20058
Merged
fix(functional-tests): harden tests against sign-out race condition#20058
Conversation
… destruction - signOut(): wait for actual 'load' event from window.location.assign instead of URL assertions fooled by intermediate SPA redirects - fillOutEmailFirstForm(): wait for email textbox visibility after hard navigation - checkWebChannelMessage(): use expect().toPass() retry pattern to survive execution context destruction from client-side redirects
chenba
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
waitForEventto make sure the page is settle before checking for headersexpectthat is a little more robust since it keeps checking on page.gotoIssue that this pull request solves
Closes: (issue number)
Checklist
Screenshots (Optional)
The last failure is because I'm rate limited from Fastly.