Conversation
29bd601 to
ccde954
Compare
0d4b23e to
ad08936
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
.in.spec.tsformat intest/remote/test-process-registry.tsfor server lifecycle management,test-utils.tsfor common helpersjest-global-setup.tsandjest-global-teardown.tsto boot/teardown the auth server for integration teststest-server.tswith OAuth config overrides to fix assertion verification mismatchestest-ci.shto skip mocha tests whenTEST_TYPE=integration-jest, running only Jest suitestest-integration-jestnpm script to route throughtest-ci.shfor consistencymaxWorkers: 4injest.integration.config.jsMocha → Jest test parity
Issue
Closes: https://mozilla-hub.atlassian.net/browse/FXA-12621
Checklist
Other Information
Notable behavior change: The Mocha test "cannot stub the same account twice" had an un-awaited
assert.isRejected()that was effectively a no-op. The Jest version correctly tests actual server behavior as "can re-stub an unverified account".