Skip to content

Use RecoveryPhoneService.available in /account endpoint#20052

Merged
vbudhram merged 1 commit intomainfrom
fix-recovery-phone-available
Feb 12, 2026
Merged

Use RecoveryPhoneService.available in /account endpoint#20052
vbudhram merged 1 commit intomainfrom
fix-recovery-phone-available

Conversation

@vbudhram
Copy link
Contributor

@vbudhram vbudhram commented Feb 12, 2026

Because

  • We should be using the actual recovery phone service availble value...

This pull request

  • Uses the value

Issue that this pull request solves

Closes: (issue number)

Checklist

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@vbudhram vbudhram requested a review from a team as a code owner February 12, 2026 17:17
@vbudhram vbudhram self-assigned this Feb 12, 2026
@vbudhram vbudhram force-pushed the fix-recovery-phone-available branch from 9787ed2 to 37ba069 Compare February 12, 2026 17:47
@vpomerleau vpomerleau self-requested a review February 12, 2026 17:48
Copy link
Contributor

@vpomerleau vpomerleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested manually with the initial commit, and that worked as expected, but this current version mixes exists/available

@vbudhram vbudhram force-pushed the fix-recovery-phone-available branch 2 times, most recently from de25d19 to 00fec8a Compare February 12, 2026 19:43
Replace the config-only check with RecoveryPhoneService.available()
so the /account endpoint performs the same enabled + region + hasConfirmed
checks as the /recovery_phone/available endpoint. Returns false explicitly
when geo location is unavailable.
@vbudhram vbudhram force-pushed the fix-recovery-phone-available branch from 00fec8a to d9b7482 Compare February 12, 2026 19:51
@vbudhram vbudhram requested a review from vpomerleau February 12, 2026 19:53
Copy link
Contributor

@vpomerleau vpomerleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I didn't retest manually but code LGTM

@vbudhram vbudhram merged commit 9172ae7 into main Feb 12, 2026
20 checks passed
@vbudhram vbudhram deleted the fix-recovery-phone-available branch February 12, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants