feat(email): add templates for passwordless#20050
Conversation
StaberindeZA
force-pushed
the
fxa-13016-otp-email
branch
2 times, most recently
from
593453d to
81838f8
Compare
|
|
||
| <mj-text css-class="text-body"> | ||
| <span data-l10n-id="passwordless-signin-otp-request"> | ||
| We received a sign-in request for your Mozilla account from: |
There was a problem hiding this comment.
Does product envision these emails being very different? Currently the only difference is this line between the two. I wonder if we can keep the mailer functions but use the same email tempate and re-render differently based on that.
There was a problem hiding this comment.
The biggest issue I noticed is that the subject line is different for the 2 emails, and I'm not sure if there's currently an email with a "dynamic" subject line, or if there should be one.
There's also currently an open question out to the copywriters about changing one string, so there would be multiple strings that are different between the 2 emails.
That's mostly why I leaned towards 2, but I'm happy to look at merging the 2 if that's preferred.
StaberindeZA
force-pushed
the
fxa-13016-otp-email
branch
3 times, most recently
from
e7f67e2 to
8bb1867
Compare
Because: - Need new email templates for passwordless signin and signup otp This commit: - Adds passwordlessSigninOtp email template - Adds passwordlessSignupOtp email template Closes #FXA-13016
StaberindeZA
force-pushed
the
fxa-13016-otp-email
branch
from
8bb1867 to
09bebad
Compare
| resource_class: | ||
| type: string | ||
| default: large | ||
| default: xlarge |
There was a problem hiding this comment.
note: The Unit Test job was OOM'ing so I bumped the size so that all auth-server tests get run.
2 participants
Because
This pull request
Issue that this pull request solves
Closes: # FXA-13016
Checklist
Put an
xin the boxes that applyScreenshots (Optional)